Rework DateRangeFilter #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 15, 2018 04:12
- Replaces the 'options' data structure with standard form field choices and a 'filters' dict, which contains the date filters separately. - Choices now use descriptive string values instead of integers.
rpkilby
force-pushed
the
rework-daterangefilter
branch
from
7adda20
to
67e7bff
Compare
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 97.95% 98.04% +0.09%
==========================================
Files 15 15
Lines 1122 1124 +2
==========================================
+ Hits 1099 1102 +3
+ Misses 23 22 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update to
DateRangeFilter.Changes:
optionsdata structure with standard form fieldchoicesand afiltersdict, which contains the date filters separately. This is slightly easier to override.empty_labeloption and corresponding setting, instead of ignoring it.nowfunction, per the filters tests. This fixes Fix date range tests by asserting what isn't valid #400.