Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DeprecationWarning on python 3.7 #989

Merged
merged 2 commits into from
Dec 17, 2018
Merged

fix DeprecationWarning on python 3.7 #989

merged 2 commits into from
Dec 17, 2018

Conversation

therefromhere
Copy link
Contributor

Resolves #988

@codecov-io
Copy link

codecov-io commented Oct 29, 2018 •
edited
Loading

Codecov Report

Merging #989 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          15       15           
  Lines        1198     1198           
=======================================
  Hits         1178     1178           
  Misses         20       20
Impacted Files Coverage Δ
django_filters/widgets.py 95.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4112ad...70c994f. Read the comment docs.

carltongibson
carltongibson approved these changes Dec 17, 2018
View reviewed changes
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super.

@carltongibson carltongibson merged commit 1f47e36 into carltongibson:master Dec 17, 2018
@therefromhere therefromhere deleted the py38_compat branch December 17, 2018 18:40
sneto pushed a commit to sneto/django-filter that referenced this pull request Feb 4, 2019
@therefromhere @sneto
fix DeprecationWarning on python 3.7 (carltongibson#989)
1b008ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@therefromhere @codecov-io @carltongibson @auvipy