Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved chanify:// naming confusion #1266

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 31, 2024

Description:

Related issue (if applicable): #1265

the chanify:// plugin had chantify:// and Chantify references everywhere. This was overlooked during it's original comit to the code base and corrected in this PR.

See https://chaify.net/ for details on this plugin. Apprise Wiki Page also updated to reflect this inconistency

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1265-chanify-plugin-cleanup

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "chanify://token"

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (0a9f338) to head (5d7b418).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         159      159           
  Lines       20715    20715           
  Branches     3724     3724           
=======================================
  Hits        20584    20584           
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit f892936 into master Dec 31, 2024
13 checks passed
@dgtlmoon
Copy link
Contributor

See https://chaify.net/ ..

actually https://www.chanify.net/ :)

it's interesting how this name is so confusing yet so simple, it caught me out for a long time too!

<3 happy new year, thanks for all your hard work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants