Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lrucache #295

Merged
merged 8 commits into from
May 18, 2024
Merged

Lrucache #295

merged 8 commits into from
May 18, 2024

Conversation

cvzi
Copy link
Contributor

@cvzi cvzi commented May 15, 2024

Changes:

  • Fix some of the type: ignore in core.py and tokenizer.py
  • Move helper functions from tests into separate file utils/testutils.py
  • Replace usage of private _EMOJI_UNICODE in tests
  • Add an option to run tests in random order with pytest --shuffle
  • Run tests in normal and random order in CI
  • Upgrade CI to ubuntu-22.04
  • Add pypy-3.10 to CI tests, we have listed pypy as supported, so we should test it
  • Use @functools.lru_cache to reverse EMOJI_DATA with new function get_emoji_by_name() Code enhancements suggestions #292
  • Move get_emoji_unicode_dict(), get_aliases_unicode_dict(), _EMOJI_UNICODE and _ALIASES_UNICODE to testutils. They are not longer needed with the new get_emoji_by_name() function, but they are still used in the tests
  • Update Unicode translation to release-45, but there were no changes to any emoji translations

cvzi added 5 commits May 15, 2024 22:19
* move pytest import mode to importlib
* move helper functions for tests into utils/testutils.py
* replace private `_EMOJI_UNICODE` in tests
* add option to pytest to run tests in random order with `pytest --shuffle`
Upgrade to ubuntu 22.04
i.e. get an emoji from a shortcode/:emoji_name:
@cvzi cvzi marked this pull request as ready for review May 16, 2024 19:52
it is not necessary after all
@TahirJalilov
Copy link
Collaborator

@cvzi Thank you!

@TahirJalilov TahirJalilov merged commit 77624cd into carpedm20:master May 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants