Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise timing #240

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jcohen02
Copy link
Contributor

@jcohen02 jcohen02 commented Jul 31, 2024

This PR adds exercise timing to the episodes that include exercises but didn't have exercise timing set previously.

For "Examples of Using Container Images in Practice" (docker-image-examples.md), there are no specific exercise callouts but the content suggests choosing one or more of the provided examples to practice using containers. I've therefore cut the "teaching" time to 10 minutes, assuming that the instructor will provide a brief overview of the different examples, and added 15 minutes exercise time. Perhaps it would even be better to increase this to 20 or 25 minutes? This is flexible since it depends on how much time the instructor wants to dedicate to this.

Closes #232.

Copy link

github-actions bot commented Jul 31, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-240

The following changes were observed in the rendered markdown documents:

 docker-image-examples.md | 4 ++--
 introduction.md          | 2 +-
 md5sum.txt               | 8 ++++----
 meet-docker.md           | 2 +-
 reproduciblity.md        | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-31 18:50:07 +0000

github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Copy link
Contributor

@aturner-epcc aturner-epcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aturner-epcc aturner-epcc merged commit 4d336cd into carpentries-incubator:main Aug 1, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Auto-generated via {sandpaper}
Source  : 4d336cd
Branch  : main
Author  : Andy Turner <a.turner@epcc.ed.ac.uk>
Time    : 2024-08-01 06:53:38 +0000
Message : Merge pull request #240 from jcohen02/fix/issue232

Add exercise timing
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Auto-generated via {sandpaper}
Source  : 3a3af72
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-01 06:54:31 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4d336cd
Branch  : main
Author  : Andy Turner <a.turner@epcc.ed.ac.uk>
Time    : 2024-08-01 06:53:38 +0000
Message : Merge pull request #240 from jcohen02/fix/issue232

Add exercise timing
@jcohen02 jcohen02 added the peer review:editorial comment Editorial comments to be addressed from the peer review label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect exercise times
2 participants