Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves objective. Closes #229 #247

Conversation

aturner-epcc
Copy link
Contributor

Improvement to objective wording as suggested by reviewer. Closes #229

Copy link

github-actions bot commented Aug 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-247

The following changes were observed in the rendered markdown documents:

 docker-hub.md | 2 +-
 md5sum.txt    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-16 09:40:08 +0000

github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Copy link
Contributor

@jcohen02 jcohen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I note a warning also appearing in the diff on an unrelated line where there's the link to profiles.html, saying that the file doesn't exist. This file is generated as part of the build process. I was under the impression from the workbench docs that the link could be to profiles.md, which does exist, and then the links are updated during the build process when the pages are generated, however, this didn't seem to be working for some reason.

@aturner-epcc aturner-epcc merged commit 79a2f1a into carpentries-incubator:main Oct 12, 2024
3 checks passed
@aturner-epcc aturner-epcc deleted the aturner-epcc/objective-i229 branch October 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter 5: The objective 'Explain how the Docker Hub augments Docker use' is not clear to me.
2 participants