[#2224] Community roles: change dates display [+ refactoring, bug fixing] #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes carpentries#2224. I forgot to include this in previous PR. Human daterange was changed so that it accepts a separate placeholder for unknown date on the right side. The function itself went through some small refactor.
These utils were defined and only used in the tests. No need to keep this code anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2224 (I forgot to include one change in the previous PR that was fixing this ticket).
Additionally, a refactor was done to
workshops.utilfile (it was split into smaller files inworkshops.utilspackage). The refactoring concentrated on:One of critical bugs fixed was related to event (request, inquiry, etc.) assignment, which was originally implemented as reacting to GET or POST requests. This was changed, as the views making changes to objects should be reacting to POST requests only, and should use CSRF mechanism.