Set default filtering for training requests #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbanaszkiewicz
approved these changes
Apr 16, 2023
| query_string = "state=&matched=" | ||
|
|
||
| # Act | ||
| rv = self.client.get(reverse("all_trainingrequests"), QUERY_STRING=query_string) |
There was a problem hiding this comment.
Interesting, I didn't know about QUERY_STRING=.
elichad
deleted the
feature/2315-Add-filter-for-default-training-requests-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315.
Stopgap for #2314 - the filtered view still performs a bit slowly on the full AMY database (link), but it shouldn't be catastrophic any more.
This implementation only sets the defaults if the user has chosen not to filter at all - i.e. it is still possible to see all training requests by explicitly selecting the blank options for these fields in the filter UI (or setting the URL query string to
?state=&matched=)Note that setting defaults for requests that do include user-selected filter choices is not recommended.