Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bulk training progress form to work with Get Involved step #2446

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Update bulk training progress form to work with Get Involved step #2446

merged 3 commits into from
Jun 28, 2023

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Jun 23, 2023 •
edited
Loading

In the interest of time, I'm raising this not against feature/instructor-checkout-changes but instead against the branch used in #2431 for review. Will not merge until #2431 is merged.

Fixes #2445.

This PR will:

  • add fields needed for the Get Involved step to the bulk training progress form
  • make the bulk form use the same JS as the individual training progress form to dynamically display fields based on options
  • expand tests of the bulk form to test adding different requirements

Screenshot showing the bottom of the all trainees page. One trainee is selected and the bulk add progress form displays the fields associated with the Get Involved requirement

@elichad elichad added this to the v4.2 milestone Jun 23, 2023
@elichad elichad self-assigned this Jun 23, 2023
@elichad elichad linked an issue Jun 23, 2023 that may be closed by this pull request
Update bulk add training progress form #2445
Closed
froggleston
froggleston approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@froggleston froggleston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pbanaszkiewicz
pbanaszkiewicz approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor UX question.

amy/trainings/forms.py Show resolved Hide resolved
@elichad elichad changed the base branch from 2408-create-get-involved-requirement to feature/instructor-checkout-changes June 28, 2023 08:27
@elichad elichad merged commit cfeaa9d into feature/instructor-checkout-changes Jun 28, 2023
@elichad elichad deleted the 2445-update-bulk-progress-form branch August 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froggleston froggleston froggleston approved these changes

@pbanaszkiewicz pbanaszkiewicz pbanaszkiewicz approved these changes

@maneesha maneesha Awaiting requested review from maneesha

Assignees

@elichad elichad

Labels
component: user interface (UI)
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

Update bulk add training progress form
3 participants
@elichad @pbanaszkiewicz @froggleston