Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that GitHub contributions are associated with a Carpentries GH organisation #2502

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Aug 3, 2023

Fixes #2470. Depends on #2492.

This just checks for "github.com/ORG" in the URL text, for all of our organisations as listed in the Carpentries Handbook: https://docs.carpentries.org/topic_folders/communications/tools/github_organisations.html.

In future we might look at storing a machine-readable list of organisations centrally and pulling the list from that, but for now @maneesha and I agreed to hardcode this list.

Screenshot:
Get Involved form with an invalid URL entered. Error and help text appears above the URL field. Error text: This URL is not associated with a repository in any of the GitHub organisations owned by The Carpentries. If you need help resolving this error, please contact us using the details at the top of this form. Help text: A link to the activity, if there is one. If you served at a workshop, enter the workshop website. If you made a GitHub contribution, enter that link and ensure it is associated with a repository in one of the GitHub organisations owned by The Carpentries (linked).

@elichad elichad added this to the v4.2 milestone Aug 3, 2023
@elichad elichad self-assigned this Aug 3, 2023
@elichad
Copy link
Contributor Author

elichad commented Aug 3, 2023

Also snuck in a change to the wording of the community meeting involvement at the request of @karenword. This doesn't affect any tests

@elichad elichad force-pushed the feature/2470-Get-involved-GH-contribution-allows-repos-in-non-Carpentries-organizations branch from 22101d8 to dffc700 Compare August 4, 2023 17:38
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@elichad elichad force-pushed the feature/2470-Get-involved-GH-contribution-allows-repos-in-non-Carpentries-organizations branch from b7bd058 to c145232 Compare August 7, 2023 12:18
@elichad elichad merged commit 7b52bd9 into develop Aug 7, 2023
8 checks passed
@elichad elichad deleted the feature/2470-Get-involved-GH-contribution-allows-repos-in-non-Carpentries-organizations branch August 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get involved GH contribution allows repos in non-Carpentries organizations
2 participants