Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emails] Scheduled email log author #2506

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

pbanaszkiewicz
Copy link
Contributor

This fixes #2484.

New field was introduced: EmailScheduledLog.author. This field is filled out by the EmailController through optional parameter author: Person | None = None in all of its methods.

The UI change is minimal and allows to quickly see who is the log entry author:
image

@pbanaszkiewicz
Copy link
Contributor Author

@elichad This is ready for your review.

@pbanaszkiewicz pbanaszkiewicz modified the milestones: v4.2, v4.3 Aug 8, 2023
Copy link
Contributor

@elichad elichad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pbanaszkiewicz pbanaszkiewicz merged commit ffa5a5e into develop Aug 11, 2023
8 checks passed
@pbanaszkiewicz pbanaszkiewicz deleted the feature/2484-scheduled-email-log-author branch August 12, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Emails] Indicate log entry author
2 participants