Remove question about learner count from WRF #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft while I figure out how to make the migration reversible |
pbanaszkiewicz
approved these changes
Aug 22, 2023
|
@elichad , saw the original pr was closed. Wasn't sure if that meant that the count field was able to be removed - double checking because it still shows on the form. |
|
@danielle06 Sorry for the confusion! The PR is closed as the development is complete, but this change hasn't been released yet. The question should disappear from the form after the next release (v4.3, planned for late October). Is that okay? |
|
@elichad , yes! No worries and thank you for the explanation. I wanted to make sure I was understanding correctly :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2308 by completely removing this field from the DB (issue comments say that this data is not used)