Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill membership when accepting workshop requests #2538

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Sep 22, 2023

Also updates fake data creation to include membership codes.
Fixes #2399

@elichad elichad added this to the v4.3 milestone Sep 22, 2023
@elichad elichad self-assigned this Sep 22, 2023
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with two very minor comments.

Comment on lines 32 to 39
<tr><th>Affiliated with a member?</th>
<td>
{{ object.member_affiliation|default:"&mdash;" }}
</td></tr>
<tr><th>Member registration code:</th>
<td>
{{ object.member_code|default:"&mdash;" }}
</td></tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation of <td>s is slightly off compared to amy/templates/includes/selforganisedsubmission_details.html.
image

member_code = ""
if member_affiliation != "no":
if randbool(0.75):
# 50% of time, use an existing member code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

75% *

@elichad elichad merged commit b50d63f into feature/member-codes Sep 25, 2023
2 checks passed
@elichad elichad deleted the feature/autofill-membership-when-accepting-requests branch September 25, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants