Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autoresponses with member codes #2561

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Update autoresponses with member codes #2561

merged 6 commits into from
Nov 6, 2023

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Oct 30, 2023

  • adds member_code field to the WRF autoresponse
  • adds member_code_override field to the TR autoresponse if it is set to True (i.e. if it wasn't used, don't include it as it may not have been displayed at all)
  • adds a warning to the TR autoresponse if member_code_override=True (i.e. if the member code is invalid)

@elichad elichad added this to the v4.3 milestone Oct 30, 2023
@elichad elichad self-assigned this Oct 30, 2023
pbanaszkiewicz
pbanaszkiewicz approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elichad elichad merged commit 3e522a2 into feature/member-codes Nov 6, 2023
2 checks passed
@elichad elichad deleted the feature/update-autoresponses branch November 6, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbanaszkiewicz pbanaszkiewicz pbanaszkiewicz approved these changes

Assignees

@elichad elichad

Labels
component: email automation
Projects
Member code enforcement
Status: Done
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@elichad @pbanaszkiewicz