hides old lesson guide #255
Conversation
There was a problem hiding this comment.
I was in the process of reviewing this PR before it was self merged. Please see my original comment below
Hi Maneesha.
Please see my comments specific to this PR below (or above -- not sure where this specific comment will appear).
Now, regarding the change in general.
-
This repository is an example of how to work on a lesson repository and gives an overview of all steps of this process. Curriculum Development Handbook has a different goal and there are different ways to look at Curriculum development: as a prerequisite for the lesson development or as a part of it. So, I personally disagree with the changes that you (previously) made to the first episode.
-
Curriculum development page says:
This is work in progress. Comments and suggestions are welcome [snip]
The episode the content of which you deleted in the previous commits was in a stable state. Moreover, content is very different. I don't think it is the right approach to replace stable content with the one that is still being developed and is of different nature.
My suggestion: undo all of these changes. We can add a note to consult with that Curriculum Development Handbook but we need to be clear that this repository has a different goal.
| @@ -4,6 +4,8 @@ redirect_to: | |||
| - https://carpentries.github.io/curriculum-development/ | |||
| questions: | |||
| - "How do we design lessons?" | |||
| hidden: True | |||
|
|
|||
There was a problem hiding this comment.
Please remove this empty line
| @@ -15,14 +15,20 @@ <h2 id="schedule">Schedule</h2> | |||
| {% endfor %} | |||
| {% assign current = site.start_time %} | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove these two empty lines
| <table class="table table-striped"> | ||
| <tr> | ||
| {% if multiday %}<td class="col-md-1"></td>{% endif %} | ||
| <td class="{% if multiday %}col-md-1{% else %}col-md-2{% endif %}"></td> | ||
| <td class="col-md-3"><a href="{{ relative_root_path }}{% link setup.md %}">Setup</a></td> | ||
| <td class="col-md-7">Download files required for the lesson</td> | ||
| </tr> | ||
|
|
There was a problem hiding this comment.
Please remove this empty line
| @@ -73,6 +82,7 @@ <h2 id="schedule">Schedule</h2> | |||
| </tr> | |||
| </table> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove this empty line
|
Thanks @maxim-belkin |
lesson_check: switch to argparse
The lesson example page (http://carpentries.github.io/lesson-example/) included a section on Lesson Design. This is deprecated in favor of the new Curriculum Development Handbook (https://carpentries.github.io/curriculum-development/).
This PR hides the Lesson Design from the Lesson Example site, while keeping the placeholder link to allow it to redirect to the new CDH. The CDH is also linked to in the top paragraph of the lesson Example page.