Merge pull request #19 from carpentries/alt-logo-lang

remove repetative logo information
carpentries · Feb 8, 2022 · 42ec4c0 · 42ec4c0
2 parents ed67610 + c88891c
commit 42ec4c0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: varnish
 Title: Front-end for The Carpentries Lesson Template
-Version: 0.1.3
+Version: 0.1.4
 Authors@R: c(
     person(given = "Zhian N.",
            family = "Kamvar",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,8 @@
+# varnish 0.1.4
+
+* Removed " logo" suffix from the logo elements, as it is redundant
+  https://webaim.org/techniques/alttext/#logos
+
 # varnish 0.1.3
 
 * Add small version of the carpentries logo

diff --git a/inst/pkgdown/templates/header.html b/inst/pkgdown/templates/header.html
@@ -2,7 +2,7 @@
   <a class="visually-hidden-focusable skip-link" href="#main-content">Skip to main content</a>
   <div class="container-fluid top-nav-container">
     <div class="col-md-6">
-      <div class="large-logo"><img alt="{{#yaml}}{{carpentry_name}}{{/yaml}} logo" src="{{#site}}{{root}}{{/site}}assets/images/{{#yaml}}{{carpentry_icon}}-logo.svg{{/yaml}}"></div>
+      <div class="large-logo"><img alt="{{#yaml}}{{carpentry_name}}{{/yaml}}" src="{{#site}}{{root}}{{/site}}assets/images/{{#yaml}}{{carpentry_icon}}-logo.svg{{/yaml}}"></div>
     </div>
     <div class="selector-container ">
       {{#yaml}}{{#language}}
@@ -45,7 +45,7 @@
       <span class="menu-title">Menu</span>
     </button>
     <div class="nav-logo">
-      <img class="small-logo" alt="{{#yaml}}{{carpentry_name}}{{/yaml}} logo" src="{{#site}}{{root}}{{/site}}assets/images/{{#yaml}}{{carpentry_icon}}-logo-sm.svg{{/yaml}}">
+      <img class="small-logo" alt="{{#yaml}}{{carpentry_name}}{{/yaml}}" src="{{#site}}{{root}}{{/site}}assets/images/{{#yaml}}{{carpentry_icon}}-logo-sm.svg{{/yaml}}">
     </div>
     <div class="lesson-title-md">
       {{#site}}{{title}}{{/site}}