Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search button is unaware of Learner/Instructor View #135

Closed
tobyhodges opened this issue May 16, 2024 · 0 comments · Fixed by #136
Closed

Search button is unaware of Learner/Instructor View #135

tobyhodges opened this issue May 16, 2024 · 0 comments · Fixed by #136

Comments

@tobyhodges
Copy link
Member

The search button navigates to the Learner View of the all-in-one page, regardless of whether it is used while in Instructor View. It would be better for the user to remain in Instructor View when using that button.
ErinBecker added a commit that referenced this issue May 17, 2024
@ErinBecker
make search aware of instructor/learner
b4d56a9 
Fixes #135
@ErinBecker ErinBecker mentioned this issue May 21, 2024
Merged
milanmlft pushed a commit to LearnToDiscover/varnish that referenced this issue May 22, 2024
@pull @ErinBecker @froggleston
[pull] main from carpentries:main (#15)
08cf866 
* make search aware of instructor/learner

Fixes carpentries#135

* fix moustache logic

* fix moustache logic

* fix link

learner aio isn't in learner folder

---------

Co-authored-by: Erin Becker <ebecker@carpentries.org>
Co-authored-by: Robert Davey <robertdavey@carpentries.org>
milanmlft pushed a commit to LearnToDiscover/varnish that referenced this issue May 23, 2024
@pull @ErinBecker @froggleston
[pull] main from carpentries:main (#17)
e90f058 
* make search aware of instructor/learner

Fixes carpentries#135

* fix moustache logic

* fix moustache logic

* fix link

learner aio isn't in learner folder

---------

Co-authored-by: Erin Becker <ebecker@carpentries.org>
Co-authored-by: Robert Davey <robertdavey@carpentries.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make "Search All in One" aware of learner/instructor distinction carpentries/varnish
1 participant
@tobyhodges