Skip to content

Commit

Permalink
Note llvm stopped updating our metadata feed
Browse files Browse the repository at this point in the history
We'll need to refactor generateCPUDetailsToFeatures.py to support the
new in-llvm CPU feature map definition files since they stopped updating
the old format in mid-2020.
  • Loading branch information
mattsta committed Jan 10, 2021
1 parent f45cfb9 commit 2b37a11
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions update-X86Targetdef.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
#!/usr/bin/env bash

# Old:
curl -O https://raw.githubusercontent.com/llvm-mirror/clang/master/include/clang/Basic/X86Target.def

# Note: as of this commit: https://github.com/llvm/llvm-project/commit/d5c28c4094324e94f6eee403022ca21c8d76998e
# llvm moved the nice feature flags from X86Target into X86Target and X86TargetParser.

# If we want to support ongoing llvm development past cooperlake, we need to refactor
# the definition parser to use the new file formats (which looks like it'll require
# maintaining more state details since we have to sync both files now?).

# For now we're just using the old format (which won't be updated anymore), but
# new CPUs aren't being added at such a huge rate of advancement where it
# matters at the moment.

# New:
#curl -O https://raw.githubusercontent.com/llvm/llvm-project/main/clang/include/clang/Basic/X86Target.def
#curl -O https://raw.githubusercontent.com/llvm/llvm-project/main/llvm/include/llvm/Support/X86TargetParser.def

0 comments on commit 2b37a11

Please sign in to comment.