-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change #cache_storage to use #storage by default to avoid confusion
Most users won't expect that they must be configured separately, like said in #2353. But we preserve ability to set cache_storage explicitly, because there can be a case which gets benefit from it. (e.g. For an application which utilizes multiple servers but does not need caches to be persisted across requests, using :fog for storage and :file for cache_storage results in smaller overhead)
Showing
4 changed files
with
22 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
629afec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change and https://github.com/carrierwaveuploader/carrierwave/pull/1879/files causes AWS S3 storage to be used as the temporary cache. We didn't grant DELETE permissions to avoid files being altered. Also, not sure if this change works well with recreate_versions! change (https://github.com/carrierwaveuploader/carrierwave/pull/1879/files)
629afec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also realized the reason we were having problems was that our Uploader class defined a
cache_dir
:Changing to an S3-backend also would require changing this path to reflect a temporary S3 bucket.