Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress RMagick warning #1681

Conversation

kirikiriyamama
Copy link

Requiring RMagick is deprecated on RMagick 2.14.0, so use rmagick instead.

Requiring `RMagick` is deprecated on RMagick 2.14.0, so use `rmagick` instead.
@kirikiriyamama kirikiriyamama force-pushed the suppress_rmagick_warning branch from c0c4db5 to 7654384 Compare June 17, 2015 10:55
@bensie bensie closed this in 71cb18b Jun 30, 2015
@thomasfedb
Copy link
Contributor

Any chance of a gem release contain this fix in the short to medium term? ✨

@optimum-dulopin
Copy link

+1

@thomasfedb
Copy link
Contributor

@jnicklas @trevorturk @bensie

@tom-lord
Copy link
Contributor

tom-lord commented Oct 2, 2015

+1 for gem release

@amrkamel
Copy link

  • 1 for gem release.

@trevorturk
Copy link
Contributor

@bensie are you handling releases nowadays? I haven't been using CW for anything for a long time, so I'm out of the loop, but can pitch in if needed, or maybe we should find a new maintainer?

@bauffman
Copy link

+1 for gem release. Why is this taking so long?

@thomasfedb
Copy link
Contributor

If you're looking for a new maintainer, then I would happily put myself forward for the role. I have contributions in rails core, and look after a few gems of my own.

@trevorturk
Copy link
Contributor

@thomasfedb thanks for volunteering. I'll add you to the github repo now, but I'll need your email address to add you to rubygems.

@bensie
Copy link
Member

bensie commented Nov 13, 2015

We have a path to 1.0 and a list of things to do before then, but the handful of us maintainers (me, @eavgerinos, @plribeiro3000) just haven't had the time to knock out the issues and get it shipped. We'll take all the help we can get!

@trevorturk
Copy link
Contributor

Ah cool @bensie -- can I leave this to you, then? I'm really not using CW at all nowadays. I don't seem to have admin access on github, so I think we'll have to get in touch with @jnicklas to request that. I think I can add people on rubygems, though, so holler if I can help with that end.

@bensie
Copy link
Member

bensie commented Nov 13, 2015

Yep I'll take care of it - I have GH access, weird that you don't - maybe you left the org? @thomasfedb have a look at the 1.0 milestone issues and the currently open PRs/issues if you have time to spare, everyone will appreciate it!

@thomasfedb
Copy link
Contributor

@trevorturk Email is thom@sfedb.com. @bensie Perhaps we can see if a 0.11.0 can be released before 1.0.0. I will go thought the old issues and PRs to see what is worth keeping, and what to close.

@trevorturk
Copy link
Contributor

Cool, I'll step out again for now, then. Thanks @bensie and @thomasfedb!

@bensie
Copy link
Member

bensie commented Nov 13, 2015

@thomasfedb Easier said than done unfortunately. There are breaking changes in master, compatibility with Ruby versions and Rails versions have changed, and picking out the stuff that doesn't affect those for a 0.11 release will be painful.

jasonadamyoung pushed a commit to extension/carrierwave that referenced this pull request Jan 21, 2016
mynock pushed a commit to mynock/carrierwave that referenced this pull request Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants