-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress RMagick warning #1681
Suppress RMagick warning #1681
Conversation
Requiring `RMagick` is deprecated on RMagick 2.14.0, so use `rmagick` instead.
c0c4db5
to
7654384
Compare
Any chance of a gem release contain this fix in the short to medium term? ✨ |
+1 |
+1 for gem release |
|
@bensie are you handling releases nowadays? I haven't been using CW for anything for a long time, so I'm out of the loop, but can pitch in if needed, or maybe we should find a new maintainer? |
+1 for gem release. Why is this taking so long? |
If you're looking for a new maintainer, then I would happily put myself forward for the role. I have contributions in rails core, and look after a few gems of my own. |
@thomasfedb thanks for volunteering. I'll add you to the github repo now, but I'll need your email address to add you to rubygems. |
We have a path to 1.0 and a list of things to do before then, but the handful of us maintainers (me, @eavgerinos, @plribeiro3000) just haven't had the time to knock out the issues and get it shipped. We'll take all the help we can get! |
Yep I'll take care of it - I have GH access, weird that you don't - maybe you left the org? @thomasfedb have a look at the 1.0 milestone issues and the currently open PRs/issues if you have time to spare, everyone will appreciate it! |
@trevorturk Email is thom@sfedb.com. @bensie Perhaps we can see if a 0.11.0 can be released before 1.0.0. I will go thought the old issues and PRs to see what is worth keeping, and what to close. |
Cool, I'll step out again for now, then. Thanks @bensie and @thomasfedb! |
@thomasfedb Easier said than done unfortunately. There are breaking changes in master, compatibility with Ruby versions and Rails versions have changed, and picking out the stuff that doesn't affect those for a 0.11 release will be painful. |
…veuploader#1681 # Conflicts: # lib/carrierwave/processing/rmagick.rb
Requiring
RMagick
is deprecated on RMagick 2.14.0, so usermagick
instead.