Fix bug when reading content_type from a CSV object linked to a file #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mshibuya could you take a look at this fix? |
|
Looks great, thanks! |
|
I think this bug also causes failures in the case where the file is empty or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2559
In my previous PR I mistakenly passed the
fileargument toMarcel::Magic.by_pathinstead ofpath. This was not an issue in the majority of cases (Fileobjects work properly) but not for a CSV, which raises aTypeError Exception: no implicit conversion of CSV into String. Since all tests were passing, this bug passed inadvertently. I added a new test to ensure it does not happen again.