Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content type detection for JSON files. #2618

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix content type detection for JSON files. #2618

merged 1 commit into from
Jul 14, 2022

Conversation

smnscp
Copy link
Contributor

@smnscp smnscp commented Jul 8, 2022

Resolves #2617

@thiagofm
Copy link
Member

Hey @smnscp,

Thanks for your contribution ❤️💜💙💚💛

Cheers.

PS: that testfile(spec/sanitized_file_spec.rb) could have some love. A lot of variable assignments could be moved to let blocks and DRY'd up. In case you are looking to contribute more, be my guest there.

@thiagofm thiagofm merged commit 0657941 into carrierwaveuploader:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content type for JSON files recognized as "invalid/invalid"
2 participants
@smnscp @thiagofm