Fix Ruby 2.7 deprecation warning on Mounter#remove? #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
reviewed
Dec 28, 2022
lib/carrierwave/mounter.rb
Outdated
| @@ -110,7 +110,7 @@ def blank? | |||
| end | |||
|
|
|||
| def remove? | |||
| remove.present? && remove !~ /\A0|false$\z/ | |||
| remove.present? && remove.to_s !~ /\A0|false$\z/ | |||
There was a problem hiding this comment.
Thanks for the PR, could you make this same as the fix in the master branch?
https://github.com/carrierwaveuploader/carrierwave/blob/master/lib/carrierwave/mounter.rb#L115
On Ruby 2.7, with deprecation warnings enabled, the Mounter#remove? code
which handles string arguments to remove that we want to be treated as
false-y ("0" and "false") was throwing a deprecation warning:
"warning: deprecated Object#=~ is called on TrueClass; it always returns
nil"
This change fixes that warning by checking if the value is TrueClass
before running the regular expression.
Note that this does not change any behaviour since the presence check
was already handling the case that a false Boolean was passed, and the
case that a true Boolean was passed was already correctly not matching
the regular expression albeit with the deprecation warning.
This fix is the same as the one on the master branch commit
9a37fc9 by mshibuya.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently working on our Ruby 2.7 to 3.0 upgrade and we're testing with deprecation warnings enabled on Ruby 2.7. Most of the warnings we've seen have been related to keyword arguments, but there was a different one coming from Carrierwave:
This PR aims to silence that warning with no change in behaviour on any version of Ruby.
Unfortunately I wasn't able to get the tests running in my M1 Mac development environment. It looks like the project has GitHub actions set up so hopefully that will work ok 😄
Sorry we're still on 1.x 😰 Many thanks to all the maintainers 🙏