Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test for https://github.com/carrierwaveuploader/carrierwave/issues/2685 #2686

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

rajyan
Copy link
Contributor

@rajyan rajyan commented Aug 17, 2023

files should not be removed on rollback if not updated

minimum reproducible example for #2685

files should not be removed on rollback if not updated
@rajyan
Copy link
Contributor Author

rajyan commented Aug 17, 2023

Confirmed that reverting #2679 solves the problem and can pass the test

97ee222

@mshibuya mshibuya merged commit 26b6bbd into carrierwaveuploader:master Aug 17, 2023
2 of 26 checks passed
@mshibuya
Copy link
Member

Sorry it's my fault. I think eb03fe1 should have fixed this.
The failing spec was so helpful, thanks 👍

@rajyan
Copy link
Contributor Author

rajyan commented Aug 17, 2023

No worries, thank you for your fast fix!

@rajyan rajyan deleted the rollback-regression branch August 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants