add skip_ssrf_protection config #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajyan
force-pushed
the
skip-ssrf-protection-config
branch
from
4c8f61b to
dd01745
Compare
rajyan
force-pushed
the
skip-ssrf-protection-config
branch
from
dd01745 to
0916696
Compare
mshibuya
reviewed
Oct 28, 2023
README.md
Outdated
| @@ -659,14 +659,15 @@ end | |||
| ## Testing with CarrierWave | |||
|
|
|||
| It's a good idea to test your uploaders in isolation. In order to speed up your | |||
| tests, it's recommended to switch off processing in your tests, and to use the | |||
| tests, it's recommended to switch off processing in your tests, disable SSRF protection, and to use the | |||
There was a problem hiding this comment.
Actually I don't recommend to do this. The users shouldn't do this without knowing what they're doing, unless they will be at risk.
Could you rephrase this part?
rajyan
commented
Oct 28, 2023
… when necessary Co-authored-by: Yohta Kimura <38206553+rajyan@users.noreply.github.com>
|
Merged in, thank you! |
|
Hi everyone, I have noticed that this feature has been long merged into master branch but not released yet. Do you have any plans on releasing this? Thanks a lot for your work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2695
Looking at these issues, a lot of people are looking for a way to disable ssrf filter in testing.
#2695
arkadiyt/ssrf_filter#33
arkadiyt/ssrf_filter#59
#2573
I believe it might worth making
skip_ssrf_protectionconfigurable.