Show warning if #filename is safeguarded as in the pre-3.x style #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I'm not sure is, whether there are other usage for |
mshibuya
force-pushed
the
warn-if-filename-is-safeguarded
branch
from
257fc34 to
127ccd5
Compare
mshibuya
force-pushed
the
warn-if-filename-is-safeguarded
branch
from
127ccd5 to
21e346e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2708 (comment)
I'm not totally sure that this is side-effect-free (there can be a legitimate case for #filename not to return value?) , but at least it can be helpful to some people.
I want to hear your opinion.
@y-yagi @RachalCassity @rajyan @ryan-mcneil
Closes #2708, Refs. #2659