This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
Recover Funds + Minimum Payout in Scalar Market #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The recoverFunds function is working as intended and has been tested on rinkeby. Only conditions for it to be functional is that the KPI has been initialized and the collateral is obviously not recoverable this way and only through the redeem() function. The minimum payout amount functionality has not yet been tested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
add the functionality that makes it possible to recover ERC20 tokens sent to the contract which aren't the collateral back to the creator.
add ability to have a minimum payout amount for the KPI token in a scalar market. So that even if the lower bound is not met holders can still redeem a fraction of the collateral.