Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split normalize_config into two functions #12

Closed
Macr0Nerd opened this issue Sep 29, 2022 · 2 comments · Fixed by #27
Closed

Split normalize_config into two functions #12

Macr0Nerd opened this issue Sep 29, 2022 · 2 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Macr0Nerd
Copy link
Collaborator

The Issue

In src/forge/common.py there is a function normalize_config. It is used to normalize the configuration values, but it currently does too many things.

The Solution

Separate normalize_config into parse_additional_config and normalize_config where parse_additional_config will handle the extra functionality in processing the additional config. Replace the function calls to normalize_config where it calls the additional config part of the function.

Notes

The additional config part of normalize_config is called in main.py around line 140 and in yaml_loader.py around 230.

@Macr0Nerd Macr0Nerd added enhancement New feature or request hacktoberfest good first issue Good for newcomers labels Sep 29, 2022
@donheshanthaka
Copy link
Contributor

Hey there, can you assign me to this task? i have already started working on it. :)

@jagmoreira
Copy link
Collaborator

Closed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants