Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split normalize_config into two functions #27

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Split normalize_config into two functions #27

merged 4 commits into from
Oct 4, 2022

Conversation

donheshanthaka
Copy link
Contributor

Split normalize_config into two functions.

Kindly make sure to add the hacktoberfest-accepted tag when accepting this PR.

Thank you.

@Macr0Nerd Macr0Nerd changed the base branch from main to dev September 30, 2022 19:45
@Macr0Nerd
Copy link
Collaborator

@donheshanthaka Thank you for the PR! Could you update the tests as well for this so that we can verify it passes the workflows? If you need help with this, feel free to ask for help! Thank you again!

@donheshanthaka
Copy link
Contributor Author

Hey there, i have updated the tests, can you check on them and let me know.

@donheshanthaka
Copy link
Contributor Author

Hey there, i have updated the testing on parse_additional_config function.

Macr0Nerd
Macr0Nerd approved these changes Oct 3, 2022
View reviewed changes
tests/test_common.py Show resolved Hide resolved
@donheshanthaka
Copy link
Contributor Author

Hey there, do you want me to remove the other test?

@Macr0Nerd
Copy link
Collaborator

Hey there, do you want me to remove the other test?

No, that's not necessary. Those are still useful for testing the normalize config. You had just also included those duplicated tests for parse_additional_config, which only needs a specific test set.

@donheshanthaka
Copy link
Contributor Author

Okay sure, it was really nice working on this project so far :)

@Macr0Nerd
Copy link
Collaborator

Okay sure, it was really nice working on this project so far :)

It was great having you contribute! Please feel welcome to take on any of the other issues, propose your own, or spread the word about the project. Have a happy Hacktoberfest!

@Macr0Nerd Macr0Nerd linked an issue Oct 3, 2022 that may be closed by this pull request
Split normalize_config into two functions #12
Closed
@npatel-cars npatel-cars merged commit 4457a2d into carsdotcom:dev Oct 4, 2022
@jagmoreira jagmoreira mentioned this pull request Oct 26, 2022
Closed
npatel-cars added a commit that referenced this pull request Oct 27, 2022
@npatel-cars @Macr0Nerd
@donheshanthaka @jagmoreira @Alig1493
merge dev to main (#38)
05bbfdf 
* Split normalize_config into two functions (#27)

* Split normalize_config into two functions

* Add test cases for normalize_config and parse_additional_config

* Bug Fix: on test_parse_additional_config

* Update test_parse_additional_config

* Added new badges to the Readme (#30)

* Move EC2 pricing calls to single function. (#29)

* Added more clear SSH error message for improper credentials

* Updated changelog

* Fixed changelog

* Updated SSH credential error message

* Add tests for ssh.py module.

* Add coverage as a test dependency.

* Update changelog and fix style.

* Add unittests for rsync module. (#33)

* Add tests for yaml_loader.py to increase coverage (#34)

* Add tests for yaml_loader.py to increase coverage

* remove redundant imports

Co-authored-by: ali <mohammed.zubair@crunch.io>

* moved function  outside for better testing (#35)

Co-authored-by: ali <mohammed.zubair@crunch.io>

* Added venv to .gitignore

* bump version (#37)

* Added venv to .gitignore

* bump version

bump version so we can merge with main

* Update CHANGELOG.md

update link for unreleased

* Update CHANGELOG.md

update link for unreleased

Co-authored-by: Gabriele A. Ron <developer@groncyber.com>

Co-authored-by: Gabe Ron <developer@groncyber.com>
Co-authored-by: Heshanthaka <heshanthaka007@gmail.com>
Co-authored-by: Joao Moreira <13685125+jagmoreira@users.noreply.github.com>
Co-authored-by: Gabriele A. Ron <gron@cars.com>
Co-authored-by: Mohammed Ali Zubair <mazg1493@gmail.com>
Co-authored-by: ali <mohammed.zubair@crunch.io>
jagmoreira added a commit that referenced this pull request Dec 11, 2024
@jagmoreira @npatel-cars
@Macr0Nerd @donheshanthaka @Alig1493
Resolving merge conflicts (#53)
57e6a02 
* merge dev to main (#38)

* Split normalize_config into two functions (#27)

* Split normalize_config into two functions

* Add test cases for normalize_config and parse_additional_config

* Bug Fix: on test_parse_additional_config

* Update test_parse_additional_config

* Added new badges to the Readme (#30)

* Move EC2 pricing calls to single function. (#29)

* Added more clear SSH error message for improper credentials

* Updated changelog

* Fixed changelog

* Updated SSH credential error message

* Add tests for ssh.py module.

* Add coverage as a test dependency.

* Update changelog and fix style.

* Add unittests for rsync module. (#33)

* Add tests for yaml_loader.py to increase coverage (#34)

* Add tests for yaml_loader.py to increase coverage

* remove redundant imports

Co-authored-by: ali <mohammed.zubair@crunch.io>

* moved function  outside for better testing (#35)

Co-authored-by: ali <mohammed.zubair@crunch.io>

* Added venv to .gitignore

* bump version (#37)

* Added venv to .gitignore

* bump version

bump version so we can merge with main

* Update CHANGELOG.md

update link for unreleased

* Update CHANGELOG.md

update link for unreleased

Co-authored-by: Gabriele A. Ron <developer@groncyber.com>

Co-authored-by: Gabe Ron <developer@groncyber.com>
Co-authored-by: Heshanthaka <heshanthaka007@gmail.com>
Co-authored-by: Joao Moreira <13685125+jagmoreira@users.noreply.github.com>
Co-authored-by: Gabriele A. Ron <gron@cars.com>
Co-authored-by: Mohammed Ali Zubair <mazg1493@gmail.com>
Co-authored-by: ali <mohammed.zubair@crunch.io>

* Add log message to inform user of rsync delay.

* Add missing changelog links.

* Bump minimum python to 3.9.

---------

Co-authored-by: npatel-cars <50211387+npatel-cars@users.noreply.github.com>
Co-authored-by: Gabe Ron <developer@groncyber.com>
Co-authored-by: Heshanthaka <heshanthaka007@gmail.com>
Co-authored-by: Gabriele A. Ron <gron@cars.com>
Co-authored-by: Mohammed Ali Zubair <mazg1493@gmail.com>
Co-authored-by: ali <mohammed.zubair@crunch.io>
jagmoreira added a commit that referenced this pull request Dec 13, 2024
@jagmoreira @Macr0Nerd
@donheshanthaka @npatel-cars @Alig1493
Release 1.1.1 - 2nd attempt (#54)
2a33e52 
* Split normalize_config into two functions (#27)

* Split normalize_config into two functions

* Add test cases for normalize_config and parse_additional_config

* Bug Fix: on test_parse_additional_config

* Update test_parse_additional_config

* Added new badges to the Readme (#30)

* Move EC2 pricing calls to single function. (#29)

* Added more clear SSH error message for improper credentials

* Updated changelog

* Fixed changelog

* Updated SSH credential error message

* Add tests for ssh.py module.

* Add coverage as a test dependency.

* Update changelog and fix style.

* Add unittests for rsync module. (#33)

* Add tests for yaml_loader.py to increase coverage (#34)

* Add tests for yaml_loader.py to increase coverage

* remove redundant imports

Co-authored-by: ali <mohammed.zubair@crunch.io>

* moved function  outside for better testing (#35)

Co-authored-by: ali <mohammed.zubair@crunch.io>

* Added venv to .gitignore

* bump version (#37)

* Added venv to .gitignore

* bump version

bump version so we can merge with main

* Update CHANGELOG.md

update link for unreleased

* Update CHANGELOG.md

update link for unreleased

Co-authored-by: Gabriele A. Ron <developer@groncyber.com>

* increase test coverage for forge/destory.py (#39)

Co-authored-by: ali <mohammed.zubair@crunch.io>

* Add a configurable spot strategy

* Updated tests

* Fixed tests for multi-az

* Updated documentation for multi-az

* Add multi-az functionality

* Add spot retries and failover

* Update documentation

* Bumped version

* Bumped version to 1.1.0

* Updated maintainers

* Fixed region bug in create.py

* 1.1.1

* Fixed automatic multi-worker allocation bug

* Updated dependencies

* Added destroy_on_create

* Fixed potential bug

* Moved to get_nlist()

* Version 1.2.0

* Add create_timeout configuration option

* Remove default create_timeout setting

* Fix create_timeout check

* Reduce version to 1.1.0

* Remove Hacktoberfest 2022 branding

* GPU Fix (#47)

* Fix gpu flag not being parsed properly.

* Update changelog.

* Add error reporting for RAM/CPU misconfigurations

* Add retries and return code to rsync

* Bump version to 1.1.1

* Add minute timer after create to engine

* Add msg in engine to inform user of Rsync delay (#51)

* Add log message to inform user of rsync delay.

* Add missing changelog links.

* Resolving merge conflicts (#53)

* merge dev to main (#38)

* Split normalize_config into two functions (#27)

* Split normalize_config into two functions

* Add test cases for normalize_config and parse_additional_config

* Bug Fix: on test_parse_additional_config

* Update test_parse_additional_config

* Added new badges to the Readme (#30)

* Move EC2 pricing calls to single function. (#29)

* Added more clear SSH error message for improper credentials

* Updated changelog

* Fixed changelog

* Updated SSH credential error message

* Add tests for ssh.py module.

* Add coverage as a test dependency.

* Update changelog and fix style.

* Add unittests for rsync module. (#33)

* Add tests for yaml_loader.py to increase coverage (#34)

* Add tests for yaml_loader.py to increase coverage

* remove redundant imports

Co-authored-by: ali <mohammed.zubair@crunch.io>

* moved function  outside for better testing (#35)

Co-authored-by: ali <mohammed.zubair@crunch.io>

* Added venv to .gitignore

* bump version (#37)

* Added venv to .gitignore

* bump version

bump version so we can merge with main

* Update CHANGELOG.md

update link for unreleased

* Update CHANGELOG.md

update link for unreleased

Co-authored-by: Gabriele A. Ron <developer@groncyber.com>

Co-authored-by: Gabe Ron <developer@groncyber.com>
Co-authored-by: Heshanthaka <heshanthaka007@gmail.com>
Co-authored-by: Joao Moreira <13685125+jagmoreira@users.noreply.github.com>
Co-authored-by: Gabriele A. Ron <gron@cars.com>
Co-authored-by: Mohammed Ali Zubair <mazg1493@gmail.com>
Co-authored-by: ali <mohammed.zubair@crunch.io>

* Add log message to inform user of rsync delay.

* Add missing changelog links.

* Bump minimum python to 3.9.

---------

Co-authored-by: npatel-cars <50211387+npatel-cars@users.noreply.github.com>
Co-authored-by: Gabe Ron <developer@groncyber.com>
Co-authored-by: Heshanthaka <heshanthaka007@gmail.com>
Co-authored-by: Gabriele A. Ron <gron@cars.com>
Co-authored-by: Mohammed Ali Zubair <mazg1493@gmail.com>
Co-authored-by: ali <mohammed.zubair@crunch.io>

* Update release date.

---------

Co-authored-by: Gabe Ron <developer@groncyber.com>
Co-authored-by: Heshanthaka <heshanthaka007@gmail.com>
Co-authored-by: npatel-cars <50211387+npatel-cars@users.noreply.github.com>
Co-authored-by: Gabriele A. Ron <gron@cars.com>
Co-authored-by: Mohammed Ali Zubair <mazg1493@gmail.com>
Co-authored-by: ali <mohammed.zubair@crunch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagmoreira jagmoreira jagmoreira approved these changes

@Macr0Nerd Macr0Nerd Macr0Nerd approved these changes

@npatel-cars npatel-cars npatel-cars approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split normalize_config into two functions
4 participants
@donheshanthaka @Macr0Nerd @jagmoreira @npatel-cars