Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing method name for deposits from Portal #173

Closed
7 tasks done
brunomenezes opened this issue Apr 30, 2024 · 0 comments · Fixed by #175
Closed
7 tasks done

Add missing method name for deposits from Portal #173

brunomenezes opened this issue Apr 30, 2024 · 0 comments · Fixed by #175
Assignees
Labels
Type: Enhancement Improve an existing feature / design

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Apr 30, 2024

📄 Context

Currently, in the inputs table, deposits coming from the ERC20Portal and EtherPortal display the method's name when the msgSender matches the address of such portal contracts. We are already indexing information for ERC721Portal, ERC1155SinglePortal and ERC1155BatchPortal but still displaying the ?

✔️ Solution

Implement the method-resolver for each missing portal and display the method name described in the above documentation.

📈 Subtasks

  • implement the method resolver for ERC721Portal.
  • Implement the method resolver for ERC1155SinglePortal.
  • Implement the method resolver for ERC1155BatchPortal.
  • Add unit tests.

🎯 Definition of Done

  • The user can see the method name from inputs coming from the ERC721Portal.
  • The user can see the method name from inputs coming from the ERC1155SinglePortal.
  • The user can see the method name from inputs coming from the ERC1155BatchPortal.
@brunomenezes brunomenezes added the Type: Enhancement Improve an existing feature / design label Apr 30, 2024
@nevendyulgerov nevendyulgerov self-assigned this May 5, 2024
@nevendyulgerov nevendyulgerov linked a pull request May 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improve an existing feature / design
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants