Feature: ERC-1155 Transfers #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
10 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brunomenezes
force-pushed
the
feature/erc-1155-deposit
branch
from
6b85cd2
to
a4299e1
Compare
brunomenezes
force-pushed
the
feature/erc-1155-deposit
branch
from
f628461
to
9de6949
Compare
After the send-transaction mocks refactoring, the mocks behave as expected, deeming the WagmiProvider HoC and Vitest dangerouslyIgnoreUnhandledErrors flag unnecessary.
…ntract supported interface.
…the single behaviour.
…Value instead of useDebouncedState
…h single and batch ERC-1155 deposits.
brunomenezes
force-pushed
the
feature/erc-1155-deposit
branch
from
c46ab99
to
c6d0f34
Compare
nevendyulgerov
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
code changes to support multi-token transfers through available portals ERC-1155 Batch Portal and ERC-1155 Single Portal.
I will get ahead and explain some rationale for the decisions I made. Note that only one component is exported, but based on the mode, it will pick one form or the other. There are shared components and validators where due, but the amount of differences in what makes one or the other form ready and given the way the
hookswork would increase the difficulty in maintenance (The most critical piece to me. Developing is easy, maintaining is hard) given the number of variables to look after to enable or not these calls (only because of this eager nature of hooks), also other logical variables to decide when action buttons should be enabled or not that would be another unnecessary complexity. So there you have it, dear reviewer(s)The implementation was done keeping in mind the specification EIP-1155. At the moment, the only thing ruled out is the possible use of
localein theURIfori18n/i10n.Summary of changes: