Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add formatting for JSON content in the input-details. #202

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

brunomenezes
Copy link
Collaborator

Summary

Apply code changes to improve readability in the input-details area. When the input payload is in a valid JSON format, the content inside the <TextArea /> will be formatted to give better readability.

2024-06-18 15 48 46

I noticed a few oddities within the data already on-chain. Below are examples: One is a valid JSON format, and the other looks like one, but it is a string escaping other strings, therefore formatting will not be applied.

Good format:

{"name": "my-app-action", "value":"some_value"}

Bad format:

"{\"method\":\"create_something\",\"data\":{}}"

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:55am

@brunomenezes brunomenezes merged commit 9ae36cb into main Jun 18, 2024
11 checks passed
@brunomenezes brunomenezes deleted the fix/input-details-json-format branch June 18, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants