Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#216 Improve voucher execution error handling #219

Merged
merged 2 commits into from
Aug 2, 2024
Merged

#216 Improve voucher execution error handling #219

merged 2 commits into from
Aug 2, 2024

Conversation

nevendyulgerov
Copy link
Contributor

Summary:

  • Made sure the Execute button remains disabled if the prepare call is pending or has failed
  • Displayed an alert when the prepare call has failed with the relevant error message
  • Displayed Preparing voucher... text in the button for voucher execution while the prepare call is pending
  • Refactored types within the VoucherExecution component

@nevendyulgerov nevendyulgerov self-assigned this Jul 19, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-base-mainnet 🛑 Canceled (Inspect) Aug 2, 2024 0:26am
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 0:26am
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 0:26am
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 0:26am
rollups-explorer-optimism-sepolia 🛑 Canceled (Inspect) Aug 2, 2024 0:26am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 0:26am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 0:26am

@nevendyulgerov nevendyulgerov linked an issue Jul 19, 2024 that may be closed by this pull request
Voucher Execution Unhandled Error #216
Closed
@brunomenezes brunomenezes force-pushed the 216-improve-voucher-execution-error-handling branch from 31efb82 to b1f9b4c Compare July 21, 2024 22:26
@nevendyulgerov nevendyulgerov added the Type: Bug Something isn't working label Aug 1, 2024
@brunomenezes brunomenezes force-pushed the 216-improve-voucher-execution-error-handling branch from b1f9b4c to 751dbdb Compare August 1, 2024 23:34
@brunomenezes brunomenezes force-pushed the 216-improve-voucher-execution-error-handling branch from 751dbdb to 40bf544 Compare August 1, 2024 23:38
@brunomenezes brunomenezes merged commit 9f00389 into main Aug 2, 2024
14 of 17 checks passed
@brunomenezes brunomenezes deleted the 216-improve-voucher-execution-error-handling branch August 2, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@tuler tuler Awaiting requested review from tuler

Assignees

@nevendyulgerov nevendyulgerov

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Voucher Execution Unhandled Error
2 participants
@nevendyulgerov @brunomenezes