#220 Upgrade mantine packages #223
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nevendyulgerov
added
the
Type: Chore
|
@nevendyulgerov , the PR need a rebase. It may need to address other parts for the |
nevendyulgerov
force-pushed
the
feature/220-update-mantine-packages
branch
from
4a0be0b
to
ff805b1
Compare
nevendyulgerov
force-pushed
the
feature/220-update-mantine-packages
branch
from
55755dc
to
cb66073
Compare
…Value instead of setValues function
|
|
||
| if (transformedValues.formMode === "EDITION" && !initialValRef.current) | ||
| const setFieldValue = useCallback((name: string, value: unknown) => { |
There was a problem hiding this comment.
I had to cache this function, otherwise it was breaking the specifications page due to an infinite state update loop.
| @@ -307,7 +307,8 @@ const DepositFormSingle: FC<Props> = (props) => { | |||
| "erc1155Address", | |||
| formattedValue, | |||
| ); | |||
| form.setValues({ amount: "", tokenId: "" }); | |||
| form.setFieldValue("amount", ""); | |||
There was a problem hiding this comment.
Using setValues here was causing the errors to disappear like so:
Screen.Recording.2024-08-09.at.11.37.11.mov
Switching to setFieldValue mitigates the issue:
Screen.Recording.2024-08-09.at.13.57.01.mov
There was a problem hiding this comment.
Nice! It is sad that a few regressions were introduced. I believe on version 7.8.x is where most were added. Before, setValues() would have the same result as Object.assign(target, source). Nonetheless, I think the changes are better by addressing only the bits causing troubles rather than changing the validation behaviour on every form.
I upgraded all
mantinepackages to their latest versions in all apps/packages that use them and tested for regressions.In regards to the
@mantine/formspackage, I noticed a runtime error on the/specifications/newpage that was causing the page to break. The issue was coming from theform.setFieldValuefunction being passed as a dependency to other hooks. Removing it from the dependency array solved that issue. More on this - here.Another thing I noticed was issues with some forms using
setValuesfunction. This function was causing the validation to be reset for the form resulting in error messages disappearing unexpectedly. Some unit tests were failing because of this. Switching tosetFieldValuesolved that issue.