Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add EtherPortal Specification #224

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Aug 2, 2024

Summary

I have added the missing Ether Portal specification. Code change covers a new test case for the decoding engine with a real sample from EtherPortal.

Reviewers, if happy and upon approval, please feel free to merge it as it will positively reflect on automatically decoding EtherPortal-related inputs.

PS: No changes to the underlying decoding logic.

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:19am

Copy link
Contributor

@nevendyulgerov nevendyulgerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nevendyulgerov nevendyulgerov merged commit 90972f0 into main Aug 2, 2024
19 checks passed
@nevendyulgerov nevendyulgerov deleted the feat/add-ether-portal-spec branch August 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants