-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/adjustments for multichain indexed api #233
Merged
brunomenezes
merged 11 commits into
main
from
refactor/adjustments-for-multichain-indexed-api
Aug 29, 2024
Merged
Refactor/adjustments for multichain indexed api #233
brunomenezes
merged 11 commits into
main
from
refactor/adjustments-for-multichain-indexed-api
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…server and front ends.
…ing of vars and generating expected ID.
…ing correct props
… and also using the correct prop for Address.
brunomenezes
force-pushed
the
refactor/adjustments-for-multichain-indexed-api
branch
from
August 27, 2024 20:22
ce342f4
to
bd2d263
Compare
…atching for retrocompatibility.
brunomenezes
force-pushed
the
refactor/adjustments-for-multichain-indexed-api
branch
from
August 27, 2024 22:03
4bcaf02
to
70e0e27
Compare
nevendyulgerov
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
brunomenezes
deleted the
refactor/adjustments-for-multichain-indexed-api
branch
August 29, 2024 00:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to use a multichain indexed API. The strategy of one frontend per chain (e.g. sepolia.cartesiscan.io) will continue but will soon be replaced by only one frontend that will be available (i.e. cartesiscan.io) that deals with all the indexed chains.
Related to PR opened on rollups-explorer-api cartesi/rollups-explorer-api#42.
Will come out of
DRAFT
once the below points are all green:codegen.ts
with a new API endpoint. 🟢PS: Vercel and dependents (i.e. E2E) will be all broken as expected.