Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#45 Fix issue with non-digit symbols for amount input in ERC20DepositForm #49

Merged
merged 4 commits into from
Nov 11, 2023
Merged

#45 Fix issue with non-digit symbols for amount input in ERC20DepositForm #49

merged 4 commits into from
Nov 11, 2023

Conversation

nevendyulgerov
Copy link
Contributor

No description provided.

@nevendyulgerov nevendyulgerov added the Type: Bug Something isn't working label Nov 6, 2023
@nevendyulgerov nevendyulgerov self-assigned this Nov 6, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 2:08pm
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 2:08pm
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 2:08pm

@nevendyulgerov nevendyulgerov linked an issue Nov 6, 2023 that may be closed by this pull request
Inserting non-digit symbols in the amount field in ERC20DepositForm breaks the page #45
Closed
@brunomenezes brunomenezes mentioned this pull request Nov 9, 2023
Closed
dandheedge
dandheedge approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@dandheedge dandheedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nevendyulgerov nevendyulgerov merged commit 3b40029 into main Nov 11, 2023
6 checks passed
@nevendyulgerov nevendyulgerov deleted the bugfix/45-fix-issue-with-non-digit-symbols-in-erc20-deposit-form branch November 11, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandheedge dandheedge dandheedge approved these changes

@tuler tuler Awaiting requested review from tuler

@brunomenezes brunomenezes Awaiting requested review from brunomenezes

Assignees

@nevendyulgerov nevendyulgerov

Labels
Type: Bug Something isn't working
Projects
Explorer Unit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inserting non-digit symbols in the amount field in ERC20DepositForm breaks the page
2 participants
@nevendyulgerov @dandheedge