Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility/arrow-functions-feature lint #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add compatibility/arrow-functions-feature lint #42

wants to merge 1 commit into from
+71 −1

Conversation

LinusU
Copy link

@LinusU LinusU commented Jan 18, 2025 •
edited
Loading

This is my first attempt at writing a lint!

In order to test it out properly, the MINIMUM_PHP_VERSION needs to be lowered to PHP73 since arrow functions are available on PHP 7.4+. (note: there is currently an issue with "Null Coalesce Assignment Feature" that warns for php_version = "7.4" see more info here: 95a84ce#r151496707)

mago/src/consts.rs

Line 52 in dc32663

pub const MINIMUM_PHP_VERSION: PHPVersion = PHPVersion::PHP74;

I have done that locally, and the lint seems to be working! 🎉

Screenshot 2025-01-18 at 16 05 13

azjezz
azjezz requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 😄 could you please rebase?

crates/linter/src/plugin/compatibility/rules/php74/arrow_functions_feature.rs Outdated Show resolved Hide resolved
@LinusU LinusU force-pushed the lu-arrow-functions branch from 7d04960 to 8f02f85 Compare January 20, 2025 14:01
@LinusU
Copy link
Author

LinusU commented Jan 20, 2025

Applied suggestions and rebased ✅

@azjezz azjezz added Priority: Medium This issue may be useful and needs attention. Status: Revision Needed Multiple reviewers found issues in the PR that need addressing. Type: Enhancement Request for additions or changes that improve existing functionality. Subject: Linter An issue or PR related to the linter. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz requested changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful and needs attention. Status: Revision Needed Multiple reviewers found issues in the PR that need addressing. Subject: Linter An issue or PR related to the linter. Type: Enhancement Request for additions or changes that improve existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinusU @azjezz