Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented serde_derive for enums #60

Merged
merged 3 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/cairo-serde-derive/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ proc-macro = true
proc-macro2 = "1.0.86"
quote = "1.0.37"
syn = "2.0.77"
unzip-n = "0.1.2"
198 changes: 198 additions & 0 deletions crates/cairo-serde-derive/src/derive_enum.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,198 @@
use proc_macro2::{Span, TokenStream};
use quote::quote;
use syn::{DataEnum, Ident, Type, Variant};
use unzip_n::unzip_n;

pub fn derive_enum(ident: Ident, data: DataEnum) -> TokenStream {
let matches = &data
.variants
.iter()
.map(|v| derive_enum_matches(&ident, v))
.collect::<Vec<_>>();

unzip_n!(3);
let (serialized_size, serialize, deserialize) = data
.variants
.iter()
.enumerate()
.map(|(i, v)| derive_enum_variant(&ident, i, v))
.collect::<Vec<_>>()
.into_iter()
.unzip_n_vec();

let cairo_serialized_size = quote! {
fn cairo_serialized_size(rust: &Self::RustType) -> usize {
match rust {
#(
#matches => #serialized_size,
)*
}
}
};

let cairo_serialize = quote! {
fn cairo_serialize(rust: &Self::RustType) -> Vec<::starknet::core::types::Felt> {
match rust {
#(
#matches => #serialize,
)*
}
}
};

let deserialize_matches = data
.variants
.iter()
.enumerate()
.map(|(i, _)| syn::LitInt::new(&i.to_string(), Span::call_site()))
.collect::<Vec<_>>();
let cairo_deserialize = quote! {
fn cairo_deserialize(felt: &[Felt], offset: usize) -> Result<Self::RustType, ::cainome_cairo_serde::Error> {
let offset = offset + 1;
#(
if felt[offset - 1] == ::starknet::core::types::Felt::from(#deserialize_matches) {
return Ok(#deserialize);
}
)*
Err(::cainome_cairo_serde::Error::Deserialize("Invalid variant Id".to_string()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Err(::cainome_cairo_serde::Error::Deserialize("Invalid variant Id".to_string()))
Err(::cainome_cairo_serde::Error::Deserialize(format!(
"Invalid variant Id `{}` deserializing {} at offset `{}`",
felt[offset - 1],
#ident,
offset - 1
)))

As we have the info, we should try to give more context in case this unlikely situation occurs. 👍

}
};

// There is no easy way to check for the members being staticaly sized at compile time.
// Any of the members of the composite type can have a dynamic size.
// This is why we return `None` for the `SERIALIZED_SIZE` constant.
let output = quote! {
impl ::cainome_cairo_serde::CairoSerde for #ident {
type RustType = Self;

const SERIALIZED_SIZE: Option<usize> = None;

#cairo_serialized_size
#cairo_serialize
#cairo_deserialize
}
};
output
}

fn derive_enum_matches(ident: &Ident, variant: &Variant) -> TokenStream {
let variant_ident = variant.ident.clone();
let (fields, _) = fields_idents_and_types(&variant.fields);
match &variant.fields {
syn::Fields::Named(_) => quote! {
#ident::#variant_ident { #(#fields,)* }
},
syn::Fields::Unnamed(_) => quote! {
#ident::#variant_ident(#(#fields,)*)
},
syn::Fields::Unit => quote! {
#ident::#variant_ident
},
}
}

fn derive_enum_variant(
ident: &Ident,
index: usize,
variant: &Variant,
) -> (TokenStream, TokenStream, TokenStream) {
let (fields, types) = fields_idents_and_types(&variant.fields);
(
derive_variant_cairo_serialized_size(&fields, &types),
derive_variant_cairo_serialize(index, &fields, &types),
derive_variant_cairo_deserialize(ident, variant, &fields, &types),
)
}

fn derive_variant_cairo_serialized_size(fields: &[TokenStream], types: &[Type]) -> TokenStream {
quote! {
{
1
#(
+ <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&#fields)
)*
}
}
}

fn derive_variant_cairo_serialize(
index: usize,
fields: &[TokenStream],
types: &[Type],
) -> TokenStream {
let index = syn::LitInt::new(&index.to_string(), Span::call_site());
quote! {
{
let mut result = Vec::new();
result.push(::starknet::core::types::Felt::from(#index));
#(
result.extend(<#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialize(&#fields));
)*
result
}
}
}

fn derive_variant_cairo_deserialize(
ident: &Ident,
variant: &Variant,
fields: &[TokenStream],
types: &[Type],
) -> TokenStream {
let variant_ident = &variant.ident;

match &variant.fields {
syn::Fields::Named(_) => quote! {
{
let mut current_offset = offset;
#ident::#variant_ident {
#(
#fields: {
let value = <#types as ::cainome_cairo_serde::CairoSerde>::cairo_deserialize(felt, current_offset)?;
current_offset += <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&value);
value
},
)*
}
}
},
syn::Fields::Unnamed(_) => quote! {
{
let mut current_offset = offset;
#ident::#variant_ident (
#(
{
let value = <#types as ::cainome_cairo_serde::CairoSerde>::cairo_deserialize(felt, current_offset)?;
current_offset += <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&value);
value
},
)*
)
}
},
syn::Fields::Unit => quote! { #ident::#variant_ident},
}
}

fn fields_idents_and_types(fields: &syn::Fields) -> (Vec<TokenStream>, Vec<Type>) {
fields
.iter()
.cloned()
.enumerate()
.map(field_ident_and_type)
.unzip()
}

fn field_ident_and_type((i, field): (usize, syn::Field)) -> (TokenStream, Type) {
(
field
.ident
.clone()
.map(|ident| quote! { #ident })
.unwrap_or({
let i = syn::Ident::new(&format!("__self_{}", i), Span::call_site());
quote! { #i }
}),
field.ty,
)
}
80 changes: 80 additions & 0 deletions crates/cairo-serde-derive/src/derive_struct.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
use proc_macro2::TokenStream;
use quote::quote;
use syn::{DataStruct, Ident, Type};

pub fn derive_struct(ident: Ident, data: DataStruct) -> TokenStream {
let (fields, types) = fields_accessors_and_types(&data.fields);

let cairo_serialized_size = quote! {
fn cairo_serialized_size(rust: &Self::RustType) -> usize {
0
#(
+ <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&rust.#fields)
)*
}
};

let cairo_serialize = quote! {
fn cairo_serialize(rust: &Self::RustType) -> Vec<::starknet::core::types::Felt> {
let mut result = Vec::new();
#(
result.extend(<#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialize(&rust.#fields));
)*
result
}
};

let cairo_deserialize = quote! {
fn cairo_deserialize(felt: &[Felt], offset: usize) -> Result<Self::RustType, ::cainome_cairo_serde::Error> {
let mut current_offset = offset;
Ok(Self {
#(
#fields: {
let value = <#types as ::cainome_cairo_serde::CairoSerde>::cairo_deserialize(felt, current_offset)?;
current_offset += <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&value);
value
},
)*
})
}
};

// There is no easy way to check for the members being staticaly sized at compile time.
// Any of the members of the composite type can have a dynamic size.
// This is why we return `None` for the `SERIALIZED_SIZE` constant.
let output = quote! {
impl ::cainome_cairo_serde::CairoSerde for #ident {
type RustType = Self;

const SERIALIZED_SIZE: Option<usize> = None;

#cairo_serialized_size
#cairo_serialize
#cairo_deserialize
}
};
output
}

fn fields_accessors_and_types(fields: &syn::Fields) -> (Vec<TokenStream>, Vec<Type>) {
fields
.iter()
.cloned()
.enumerate()
.map(field_accessor_and_type)
.unzip()
}

fn field_accessor_and_type((i, field): (usize, syn::Field)) -> (TokenStream, Type) {
(
field
.ident
.clone()
.map(|ident| quote! { #ident })
.unwrap_or({
let i = syn::Index::from(i);
quote! { #i }
}),
field.ty,
)
}
70 changes: 10 additions & 60 deletions crates/cairo-serde-derive/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,68 +1,18 @@
use proc_macro::{self, TokenStream};
use quote::quote;
use syn::{parse_macro_input, Data, DeriveInput, Ident, Type};
use proc_macro::{self};
use syn::{parse_macro_input, Data, DeriveInput};

mod derive_enum;
mod derive_struct;

#[proc_macro_derive(CairoSerde)]
pub fn derive(input: TokenStream) -> TokenStream {
pub fn derive(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
let DeriveInput { ident, data, .. } = parse_macro_input!(input);

let (idents, types): (Vec<Ident>, Vec<Type>) = match data {
Data::Struct(data) => data
.fields
.iter()
.cloned()
.map(|field| (field.ident.clone().unwrap(), field.ty))
.unzip(),
_ => todo!("CairoSerde can only be derived for structs at the moment"),
};

let cairo_serialized_size = quote! {
fn cairo_serialized_size(rust: &Self::RustType) -> usize {
0
#(
+ <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&rust.#idents)
)*
}
};

let cairo_serialize = quote! {
fn cairo_serialize(rust: &Self::RustType) -> Vec<::starknet::core::types::Felt> {
let mut result = Vec::new();
#(
result.extend(<#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialize(&rust.#idents));
)*
result
}
let output = match data {
Data::Struct(data) => derive_struct::derive_struct(ident, data),
Data::Enum(data) => derive_enum::derive_enum(ident, data),
Data::Union(_) => panic!("Unions are not supported for the cairo_serde_derive!"),
};

let cairo_deserialize = quote! {
fn cairo_deserialize(felt: &[Felt], offset: usize) -> Result<Self::RustType, ::cainome_cairo_serde::Error> {
let mut current_offset = offset;
Ok(Self {
#(
#idents: {
let value = <#types as ::cainome_cairo_serde::CairoSerde>::cairo_deserialize(felt, current_offset)?;
current_offset += <#types as ::cainome_cairo_serde::CairoSerde>::cairo_serialized_size(&value);
value
},
)*
})
}
};

// There is no easy way to check for the members being staticaly sized at compile time.
// Any of the members of the composite type can have a dynamic size.
// This is why we return `None` for the `SERIALIZED_SIZE` constant.
let output = quote! {
impl ::cainome::cairo_serde::CairoSerde for #ident {
type RustType = Self;

const SERIALIZED_SIZE: Option<usize> = None;

#cairo_serialized_size
#cairo_serialize
#cairo_deserialize
}
};
output.into()
}
Loading
Loading