Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Role change for @praveenrewar #747

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

praveenrewar
Copy link
Member

Summary

This is a formal request for consideration of a role change in the Carvel project by a member of the community.

Each role is defined in our contribution model document. If you would like to request mutliple roles / multiple subprojects,
please open a new issue for each request.

GitHub Username

@praveenrewar

Role Requested

  • Reviewer
  • Approver
  • Lead

Applicable Subproject

General Requirements

Role Specific Requirements

Reviewer

  • I have reviewed / authored of at least 5 substantial* pull requests to the subproject(s).

Sponsors

List of contributions to the Carvel subprojects(s)

PRs reviewed / authored

All the PRs authored by me: https://github.com/carvel-dev/kapp-controller/pulls?q=is%3Apr+author%3Apraveenrewar+is%3Amerged+-label%3Acli+
Some of the most relevant PRs are:

Issues responded to

Projects I am involved with

  • I am currently working on the proposal for dependency management.

Next Steps

  • Once your sponsors have responded with a +1 for your nomination, your request will be reviewed by the project leads. Any missing information will be requested.

*Substantial is subject to the lead's discretion (e.g. refactors, enhancements rather than grammar correction or trivial pull requests)

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for carvel ready!

Name Link
🔨 Latest commit c6da369
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/6615c771ec6465000845f4a2
😎 Deploy Preview https://deploy-preview-747--carvel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joaopapereira
Copy link
Member

With all the work that @praveenrewar has been doing for years in kapp-controller, I believe he is more than ready to become a reviewer. 😄
Thanks for all the hard work you devoted to this project.

@neil-hickey
Copy link
Contributor

+1 to @praveenrewar being a reviewer (or more ;) )! Goes above and beyond and has a deep understanding of kapp-controller. Happy to see!

@joaopapereira joaopapereira merged commit c49954c into develop Apr 17, 2024
9 checks passed
@joaopapereira joaopapereira deleted the proposal-kc-reviewer branch April 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants