Do not wait for App pause on package install pause if wait is disable…

…d. Add wait flags to pkg i pause. Signed-off-by: Soumik Majumder <soumikm@vmware.com>
carvel-dev · Feb 7, 2024 · 690d65d · 690d65d
1 parent c4a9f9d
commit 690d65d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/cli/pkg/kctrl/cmd/package/installed/create_or_update.go b/cli/pkg/kctrl/cmd/package/installed/create_or_update.go
@@ -388,9 +388,12 @@ func (o CreateOrUpdateOptions) update(client kubernetes.Interface, kcClient kccl
 		if err != nil {
 			return err
 		}
-		err = o.waitForAppPause(kcClient)
-		if err != nil {
-			return err
+
+		if o.WaitFlags.Enabled {
+			err = o.waitForAppPause(kcClient)
+			if err != nil {
+				return err
+			}
 		}
 		reconciliationPaused = true
 

diff --git a/cli/pkg/kctrl/cmd/package/installed/pause_or_kick.go b/cli/pkg/kctrl/cmd/package/installed/pause_or_kick.go
@@ -65,6 +65,12 @@ func NewPauseCmd(o *PauseOrKickOptions, flagsFactory cmdcore.FlagsFactory) *cobr
 		cmd.Use = "pause INSTALLED_PACKAGE_NAME"
 	}
 
+	o.WaitFlags.Set(cmd, flagsFactory, &cmdcore.WaitFlagsOpts{
+		AllowDisableWait: true,
+		DefaultInterval:  2 * time.Second,
+		DefaultTimeout:   5 * time.Minute,
+	})
+
 	return cmd
 }
 
@@ -165,9 +171,11 @@ func (o *PauseOrKickOptions) Kick(args []string) error {
 		return err
 	}
 
-	err = o.waitForAppPause(client)
-	if err != nil {
-		return err
+	if o.WaitFlags.Enabled {
+		err = o.waitForAppPause(client)
+		if err != nil {
+			return err
+		}
 	}
 
 	err = o.unpause(client)