Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating go version and dependencies #1133

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Updating go version and dependencies #1133

merged 2 commits into from
Mar 9, 2023

Conversation

rohitagg2020
Copy link
Contributor

@rohitagg2020 rohitagg2020 commented Mar 9, 2023 •
edited
Loading

  • Updating go to 1.19.6
  • Updated Carvel tools version
  • Updated go.etcd.io/etcd to 3.5.7

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@rohitagg2020
Updating go version to 1.19.6
7747983 
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
@rohitagg2020 rohitagg2020 changed the title Updating go version to 1.19.6 Updating go version and dependencies Mar 9, 2023
praveenrewar
praveenrewar approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitagg2020
Updating dependencies
4215585 
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
@neil-hickey neil-hickey mentioned this pull request Mar 9, 2023
Closed
neil-hickey
neil-hickey approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neil-hickey neil-hickey merged commit 922e32f into develop Mar 9, 2023
@neil-hickey neil-hickey deleted the upgrade-go-and-dependencies branch March 9, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

@neil-hickey neil-hickey neil-hickey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitagg2020 @neil-hickey @praveenrewar