-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated nginx image tag to fix e2e test failure #1252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kumari tanushree <ktanushree@vmware.com>
kumaritanushree
changed the title
Updated nginx image tag to fix test failure
Updated nginx image tag to fix e2e test failure
Jun 20, 2023
praveenrewar
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for looking into it :)
/cherry-pick v0.41.x |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
Updated nginx image tag to fix e2e test failure
/cherry-pick v0.44.x |
github-actions
bot
added
the
carvel-triage
This issue has not yet been reviewed for validity
label
Jun 20, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
Updated nginx image tag to fix e2e test failure
/cherry-pick v0.45.x |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
Updated nginx image tag to fix e2e test failure
/cherry-pick v0.46.x |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
Updated nginx image tag to fix e2e test failure
sethiyash
added a commit
that referenced
this pull request
Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test Updated nginx image tag to fix e2e test failure
kumaritanushree
added a commit
that referenced
this pull request
Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test Updated nginx image tag to fix e2e test failure
kumaritanushree
added a commit
that referenced
this pull request
Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test Updated nginx image tag to fix e2e test failure
kumaritanushree
added a commit
that referenced
this pull request
Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test Updated nginx image tag to fix e2e test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
E2E test is failing due to some change in
nginx:latest
image.Logs from nginx pod:
To fix this e2e test failure updated test to use tag
nginx:1.10
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: