Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to force HTTP Basic when fetching from git repos #1495

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

joaopapereira
Copy link
Member

What this PR does / why we need it:

Enable the vendir ability to force HTTP Basic when fetching from a git repository.

Which issue(s) this PR fixes:

Fixes #1485

Does this PR introduce a user-facing change?

Allow users to define forceHTTPBasicAuth in the fetch phase.

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, I am not sure why the tests are timing out in a kind cluster and that too after 6 hours even though we have a timeout of 60m.
One thing I noticed it that we have missed updating golang version in the kind action (cc @sethiyash)
Also, could we try to show the test logs instead of pushing them to a file and see where the timeout is happening?

@sethiyash
Copy link
Contributor

Ah! Missed it somehow, Raised this separate PR for bumping go version in kind GH action.
cc: @praveenrewar

@praveenrewar praveenrewar mentioned this pull request Feb 23, 2024
5 tasks
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
@joaopapereira
Copy link
Member Author

I just rebased with develop branch let us see if it goes through 😄

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joaopapereira joaopapereira merged commit 3cb96a5 into develop Feb 27, 2024
10 checks passed
@joaopapereira joaopapereira deleted the fixe-1485 branch February 27, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support forcing basic authentication for fetches that use git
3 participants