-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling invalid column names on kctrl list commands #1502
Handling invalid column names on kctrl list commands #1502
Conversation
1dd5f54
to
f755659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a test for one of these commands?
Tests are added. |
5770147
to
7e443bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use PrintTable in some other commands as well, do you think we should update those too since column flag is global?
1f93560
to
e44e819
Compare
Updated all the commands which are using printTable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one comment, it looks good.
Signed-off-by: rcmadhankumar <rcmadhankumar@gmail.com>
e44e819
to
9b43747
Compare
What this PR does / why we need it:
Handling invalid column names on kctrl list commands.
Sample Output:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: