Add partial support for DownwardsAPI with kctrl package release #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumik Majumder <soumikm@vmware.com>
| var _ discovery.DiscoveryInterface = &MinDiscoveryClient{} | ||
|
|
||
| func (*MinDiscoveryClient) ServerVersion() (*version.Info, error) { | ||
| return &version.Info{Major: "1", Minor: "30.0-invalid", GitVersion: "1.30.0-invalid"}, nil |
There was a problem hiding this comment.
Can this cause a problem if the packages are expecting an older version? If the ytt template have a check or if the helm template only include a certain image if the k8s version is 1.28?
There was a problem hiding this comment.
It also might be ok if we do not support this use case but it has to be documented somewhere.
There was a problem hiding this comment.
I think we will be documenting it, the expectation right now is that folks are not swapping images because of versions, they would generally be passing it along as env values if the image is expected to behave differently.
We will definitely call out the values being used in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows Packages using DownwardsAPI to obtain
kubernetesAPIsorkubernetesVersionby feeding a false value.However this value cannot be reliably used to introduce images in the template step for the time being. This does not block users who are not conditionally introducing images based on these parameters.
It mocks CoreV1 client calls made by
GetServiceAccountTokenWhich issue(s) this PR fixes:
Partially fixes #1523
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: