Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry status updates in case resource changes during reconciliation #335

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

ewrenn8
Copy link
Contributor

@ewrenn8 ewrenn8 commented Aug 12, 2021

No description provided.

pkg/packageinstall/packageinstall.go Outdated Show resolved Hide resolved
pkg/packageinstall/packageinstall.go Outdated Show resolved Hide resolved

var err error
var lastErr error
for i := 0; i < 5; i++ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for 5 retries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's just the number we went with last time we ran in to this

@ewrenn8 ewrenn8 merged commit 34e7f46 into develop Aug 12, 2021
@joe-kimmel-vmw joe-kimmel-vmw deleted the fix-pkgi-race branch August 13, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants