Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow and scripts to update homebrew formula for imgpkg #1

Merged
merged 13 commits into from
Oct 1, 2021
Merged

Add workflow and scripts to update homebrew formula for imgpkg #1

merged 13 commits into from
Oct 1, 2021

Conversation

DennisDenuto
Copy link
Contributor

WIP

Authored-by: Dennis Leon leonde@vmware.com

@DennisDenuto
Copy link
Contributor Author

@cppforlife
FYI This is a very early draft PR, that will supersede carvel-dev/imgpkg#180

@DennisDenuto
Copy link
Contributor Author

DennisDenuto commented Sep 3, 2021 •
edited
Loading

TODO:

  • iterate over the 'assets' data structure since assets might be more than different OS's.
  • determine latest version release based on commit to develop
  • provide this repo with PAT required to push to homebrew repo

@DennisDenuto DennisDenuto mentioned this pull request Sep 9, 2021
Merged
@DennisDenuto
Add workflow and scripts to update homebrew formula for imgpkg
feaec69 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Generates a homebrew formula using latest release file
a6116e6 
- add a script to help test locally

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Add hack directory
3820961 
contains assets meant for devs to use in this project

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Add hack script to generate github action workflow files via ytt
4b80f3b 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Update README
b46e739 
- give a high level description about the diff directories

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Make homebrew ytt template generic to allow adding other products suc…
380551f 
…h as ytt in the future

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Update README
09a8341 
- contains additional steps for adding a new product

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
rename schema to match targeted template
8135abc 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto DennisDenuto marked this pull request as ready for review September 17, 2021 22:58
@DennisDenuto
Copy link
Contributor Author

@cppforlife This has been tested on my fork.

Prior to merging a secret.HOMEBREW_TOKEN PAT needs to be provided in order to allow writing to homebrew-carvel repo

@DennisDenuto DennisDenuto force-pushed the automate-homebrew-for-imgpkg branch 4 times, most recently from 7faaed6 to 93f8055 Compare September 18, 2021 00:17
cppforlife
cppforlife reviewed Sep 23, 2021
View reviewed changes
scripts/homebrew_formula_schema.yml Outdated Show resolved Hide resolved
scripts/generate_homebrew_formula.sh Outdated Show resolved Hide resolved
hack/dist_schema.yml Outdated Show resolved Hide resolved
hack/dist.yml Outdated Show resolved Hide resolved
@DennisDenuto
Make job name in github action workflow derived by product name in da…
a6727a6 
…tavalue

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto DennisDenuto force-pushed the automate-homebrew-for-imgpkg branch 3 times, most recently from c19c70f to 2e473bf Compare September 24, 2021 18:39
@DennisDenuto
Add generating ARM download links if product has arm assets
9407123 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Manually add imgpkg 0.19.0
55c31a5 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Allow git pushing via deploy key
8f465f4 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto DennisDenuto merged commit 1df800f into main Oct 1, 2021
@DennisDenuto
Copy link
Contributor Author

Merging as discussed with dk

@benmoss benmoss deleted the automate-homebrew-for-imgpkg branch March 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife cppforlife left review comments

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DennisDenuto @cppforlife @vmwclabot