Bump web3 to 5.x #4
Conversation
|
cc @carver |
stefanmendoza
changed the title
stefanmendoza
changed the title
|
Removing the pytest bump from the issue name / commit message so it can be part of #6. |
| @@ -38,7 +38,7 @@ | |||
| ) | |||
|
|
|||
| install_requires = [ | |||
| 'web3>=4.0.0,<5.0.0', | |||
There was a problem hiding this comment.
No CI set up on this mini project unfortunately. Were you able to test it out?
Since it doesn't look like any code changes are needed, it would be ideal to continue to support web3 v4 as well.
There was a problem hiding this comment.
I ran
make lint && make build-docs && pytest tests
and everything looked good, but I'll attach test evidence 👍 And yeah, I agree if there's no need to drop v4 support we should keep it in there.
There was a problem hiding this comment.
Hah, yeah, this is a very alpha project. If you take a look at "tests", you'll see what I mean.
Maybe the best solution is actually to break the dependency from web3.py on ethtoken during testing. The web3 doctest only uses the ABI, so we could just copy that ABI directly into the web3 doctest for now. That would simplify our lives and remove a dependency on a not-really-maintained project.
There was a problem hiding this comment.
Notably, I think that upcoming web3 v5 changes will break ethtoken, so I'm not sure I want to mark it as supported yet. (ConciseContract will go away, for example)
There was a problem hiding this comment.
One simple test is better than no tests though :)
But yeah, ideally we wouldn't be creating a circular dependency... I can look into that and see what that would entail 🤔
There was a problem hiding this comment.
@carver here's the PR:
What was wrong?
Fixing dependency warnings found in ethereum/web3.py#829 (see here).
How was it fixed?
Try to align pytest across projects, allow ethtoken to be on 5.x alpha.
This blocks ethereum/web3.py#1175
Cute Animal Picture