Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend schema to check explicit literal values in quantities and measures + rename of main schema class to VisibilityXds + SpectrumXds #267

Merged
merged 13 commits into from
Sep 23, 2024
Merged

Extend schema to check explicit literal values in quantities and measures + rename of main schema class to VisibilityXds + SpectrumXds #267

merged 13 commits into from
Sep 23, 2024

Conversation

FedeMPouzols
Copy link
Collaborator

@FedeMPouzols FedeMPouzols commented Sep 23, 2024 •
edited
Loading

Resolved #264, see issue comments for more details, especially on measures and their allowed frames, coordinate systems, etc.

Note well:

This contribution is made under the current ALMA software agreements.                                                                                                                                                                                         
(c) European Southern Observatory, 2024                                                                                                                                                                                                                       
Copyright by ESO (in the framework of the ALMA collaboration)

@FedeMPouzols
start with lowercase time/(frame scale), fix time_weather name, add d…
ab5fa79 
…oppler_type in schema, #264
@FedeMPouzols
make creation_date UTC, #264
5df00f5
@FedeMPouzols
measures: add literals for frame/scale/format/coordinate_system etc. …
1561779 
…allowed vals, remove SkyCoordOffset, fk5->FK5, and other fixes , #264
@FedeMPouzols
xds classes: add literals for type attr, #264
b7d3472
@FedeMPouzols
measure classes: add literals for type attr, fix types in sys_cal and…
800c503 
… phase_cal, #264
@FedeMPouzols
add units in measure arrays, #264
589fe17
@FedeMPouzols
add AZELGEO to allowed sky_coord frames for now, #264
02093f9
@FedeMPouzols
data precision conversion for gain_curve, #264
d4a7776
@FedeMPouzols
weather_xds: convert_to_si and data precision conversion, #264
b8c5094
@FedeMPouzols
add remaining units and unit-specific quantity classes, #264
1cc7313
@FedeMPouzols
deprecate effective_channel_width, main type: visibility/spectrum, +1…
8d99e12 
… schema pseudo-version_number, #264
@FedeMPouzols
basic formatting of quoted literal values for different types, #264
cca7242
@FedeMPouzols
rename/split CorrelatedDataXds->VisibilityXds,SpectrumXds, #264
e8424fa
@FedeMPouzols FedeMPouzols linked an issue Sep 23, 2024 that may be closed by this pull request
Extend schema to check explicit literal values in quantities and measures #264
Closed
4 tasks
@Jan-Willem Jan-Willem merged commit 6a308ab into main Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpmw scpmw Awaiting requested review from scpmw

@Jan-Willem Jan-Willem Awaiting requested review from Jan-Willem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend schema to check explicit literal values in quantities and measures
2 participants
@FedeMPouzols @Jan-Willem